The ORM Foundation

Hi, In the Constraint Validation Report (html) Internal Uniqueness Constraints are often not verbalized (missing); same with Simple Mandatory Constraints. Can not find the pattern, except that the first FactType listed on the report usually have them verbalized, after that they are missing? For Example (model): Accountant(.name) approved Payment(.nr) Accountant(.name) processed Payment(.nr) // both unique and mandatory on the "payment side" Both are properly verbalized in the ORM verbalization Browser, but in the html Constraint Validation Report only the first one has verbalization for Internal Uniqueness Constraint and Simple Mandatory Constraint. Have VS2012 and the latest version of NORMA Any ideas?

 Sorry for the delay in replying to your query.

Matt is the only one who can give you a definitive answer.

I emailed him a week ago.

Ken

Hello Damir, 

Sorry for the slow answer. I glanced at the individual fact type pages (linked from the object types) and didn't see the issue, then I looked at an older report and saw no problem, and then procrastinated. Apparently I hadn't pulled a report in a while because this is indeed broken.

The issue traces back to changeset 1484 (April 13 2012), which updated verbalization patterns for uniqueness, mandatory, and frequency constraints. The issue is that these started using new helper objects for uniqueness verbalization. The helper objects are deferred to by the primary verbalizer, and are cached--you generally have exactly one in use at any given time, so I recycle the instance. This seems innocent enough, but the default verbalization implementation will not repeat itself. The second time a helper object of the same type was encountered (on the second fact type), the verbalizer decided the object was already verbalized (because of the recylced instance) and produced no output!

I have a local fix for this (I changed the GetHashCode and Equals functions of all helpers so they are only considered equal if they are currently repeating a verbalization). I'll get it in the next NORMA drop.

If this is mission critical for you, please let me know in a private message. Otherwise, this will be fixed in the next NORMA release.

-Matt

Thanks Matthew, no urgency here.

 Damir,

This bug has been fixed.

The fix is incorporated in the new release of NORMA published today, 29 May 2013.